X-Git-Url: http://git.droids-corp.org/?a=blobdiff_plain;f=app%2Ftest%2Ftest_string_fns.c;h=5e105d2bb98036cd1be1a1745653e556389282f3;hb=2242e701358b6d2232d2cd1c8ca5d816a08009a8;hp=1a7b0240100beb481758412aee983cc602994fbe;hpb=21a7f4e2646e1cb6b0dbd6643e5d64f72355af58;p=dpdk.git diff --git a/app/test/test_string_fns.c b/app/test/test_string_fns.c index 1a7b024010..5e105d2bb9 100644 --- a/app/test/test_string_fns.c +++ b/app/test/test_string_fns.c @@ -1,34 +1,5 @@ -/*- - * BSD LICENSE - * - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in - * the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Intel Corporation nor the names of its - * contributors may be used to endorse or promote products derived - * from this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2010-2014 Intel Corporation */ #include @@ -48,139 +19,6 @@ #define DATA_BYTE 'a' -static int -test_rte_snprintf(void) -{ - /* ================================================= - * First test with a string that will fit in buffer - * =================================================*/ - do { - int retval; - const char source[] = "This is a string that will fit in buffer"; - char buf[sizeof(source)+2]; /* make buffer big enough to fit string */ - - /* initialise buffer with characters so it can contain no nulls */ - memset(buf, DATA_BYTE, sizeof(buf)); - - /* run rte_snprintf and check results */ - retval = rte_snprintf(buf, sizeof(buf), "%s", source); - if (retval != sizeof(source) - 1) { - LOG("Error, retval = %d, expected = %u\n", - retval, (unsigned)sizeof(source)); - return -1; - } - if (buf[retval] != '\0') { - LOG("Error, resultant is not null-terminated\n"); - return -1; - } - if (memcmp(source, buf, sizeof(source)-1) != 0){ - LOG("Error, corrupt data in buffer\n"); - return -1; - } - } while (0); - - do { - /* ================================================= - * Test with a string that will get truncated - * =================================================*/ - int retval; - const char source[] = "This is a long string that won't fit in buffer"; - char buf[sizeof(source)/2]; /* make buffer half the size */ - - /* initialise buffer with characters so it can contain no nulls */ - memset(buf, DATA_BYTE, sizeof(buf)); - - /* run rte_snprintf and check results */ - retval = rte_snprintf(buf, sizeof(buf), "%s", source); - if (retval != sizeof(source) - 1) { - LOG("Error, retval = %d, expected = %u\n", - retval, (unsigned)sizeof(source)); - return -1; - } - if (buf[sizeof(buf)-1] != '\0') { - LOG("Error, buffer is not null-terminated\n"); - return -1; - } - if (memcmp(source, buf, sizeof(buf)-1) != 0){ - LOG("Error, corrupt data in buffer\n"); - return -1; - } - } while (0); - - do { - /* =========================================================== - * Test using zero-size buf to check how long a buffer we need - * ===========================================================*/ - int retval; - const char source[] = "This is a string"; - char buf[10]; - - /* call with a zero-sized non-NULL buffer, should tell how big a buffer - * we need */ - retval = rte_snprintf(buf, 0, "%s", source); - if (retval != sizeof(source) - 1) { - LOG("Call with 0-length buffer does not return correct size." - "Expected: %zu, got: %d\n", sizeof(source), retval); - return -1; - } - - /* call with a zero-sized NULL buffer, should tell how big a buffer - * we need */ - retval = rte_snprintf(NULL, 0, "%s", source); - if (retval != sizeof(source) - 1) { - LOG("Call with 0-length buffer does not return correct size." - "Expected: %zu, got: %d\n", sizeof(source), retval); - return -1; - } - - } while (0); - - do { - /* ================================================= - * Test with invalid parameter values - * =================================================*/ - const char source[] = "This is a string"; - char buf[10]; - - /* call with buffer value set to NULL is EINVAL */ - if (rte_snprintf(NULL, sizeof(buf), "%s\n", source) != -1 || - errno != EINVAL) { - LOG("Failed to get suitable error when passing NULL buffer\n"); - return -1; - } - - memset(buf, DATA_BYTE, sizeof(buf)); - /* call with a NULL format and zero-size should return error - * without affecting the buffer */ - if (rte_snprintf(buf, 0, NULL) != -1 || - errno != EINVAL) { - LOG("Failed to get suitable error when passing NULL buffer\n"); - return -1; - } - if (buf[0] != DATA_BYTE) { - LOG("Error, zero-length buffer modified after call with NULL" - " format string\n"); - return -1; - } - - /* call with a NULL format should return error but also null-terminate - * the buffer */ - if (rte_snprintf(buf, sizeof(buf), NULL) != -1 || - errno != EINVAL) { - LOG("Failed to get suitable error when passing NULL buffer\n"); - return -1; - } - if (buf[0] != '\0') { - LOG("Error, buffer not null-terminated after call with NULL" - " format string\n"); - return -1; - } - } while (0); - - LOG("%s - PASSED\n", __func__); - return 0; -} - static int test_rte_strsplit(void) { @@ -291,11 +129,57 @@ test_rte_strsplit(void) return 0; } -int +static int +test_rte_strlcat(void) +{ + /* only run actual unit tests if we have system-provided strlcat */ +#if defined(__BSD_VISIBLE) || defined(RTE_USE_LIBBSD) +#define BUF_LEN 32 + const char dst[BUF_LEN] = "Test string"; + const char src[] = " appended"; + char bsd_dst[BUF_LEN]; + char rte_dst[BUF_LEN]; + size_t i, bsd_ret, rte_ret; + + LOG("dst = '%s', strlen(dst) = %zu\n", dst, strlen(dst)); + LOG("src = '%s', strlen(src) = %zu\n", src, strlen(src)); + LOG("---\n"); + + for (i = 0; i < BUF_LEN; i++) { + /* initialize destination buffers */ + memcpy(bsd_dst, dst, BUF_LEN); + memcpy(rte_dst, dst, BUF_LEN); + /* compare implementations */ + bsd_ret = strlcat(bsd_dst, src, i); + rte_ret = rte_strlcat(rte_dst, src, i); + if (bsd_ret != rte_ret) { + LOG("Incorrect retval for buf length = %zu\n", i); + LOG("BSD: '%zu', rte: '%zu'\n", bsd_ret, rte_ret); + return -1; + } + if (memcmp(bsd_dst, rte_dst, BUF_LEN) != 0) { + LOG("Resulting buffers don't match\n"); + LOG("BSD: '%s', rte: '%s'\n", bsd_dst, rte_dst); + return -1; + } + LOG("buffer size = %zu: dst = '%s', ret = %zu\n", + i, rte_dst, rte_ret); + } + LOG("Checked %zu combinations\n", i); +#undef BUF_LEN +#endif /* defined(__BSD_VISIBLE) || defined(RTE_USE_LIBBSD) */ + + return 0; +} + +static int test_string_fns(void) { - if (test_rte_snprintf() < 0 || - test_rte_strsplit() < 0) + if (test_rte_strsplit() < 0) + return -1; + if (test_rte_strlcat() < 0) return -1; return 0; } + +REGISTER_TEST_COMMAND(string_autotest, test_string_fns);