X-Git-Url: http://git.droids-corp.org/?a=blobdiff_plain;f=devtools%2Fcheckpatches.sh;h=c314d83a29d3196d9e8b854d64984d45cf64ff1c;hb=02363e1f2c35c9ddf8fa47c955a655a53d280986;hp=b5191df08f9524f5533d2ce35f34f90cd7aade58;hpb=fcea4c8e29b68959cebb0577ca6eebebc39e8eee;p=dpdk.git diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index b5191df08f..c314d83a29 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -45,7 +45,7 @@ print_usage () { The patches to check can be from stdin, files specified on the command line, latest git commits limited with -n option, or commits in the git range - specified with -r option (default: "origin/master.."). + specified with -r option (default: "origin/main.."). END_OF_HELP } @@ -69,6 +69,14 @@ check_forbidden_additions() { # -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ "$1" || res=1 + # check %l or %ll format specifier + awk -v FOLDERS='lib drivers app examples' \ + -v EXPRESSIONS='%ll*[xud]' \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Using %l format, prefer %PRI*64 if type is [u]int64_t' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + # forbid variable declaration inside "for" loop awk -v FOLDERS='.' \ -v EXPRESSIONS='for[[:space:]]*\\((char|u?int|unsigned|s?size_t)' \ @@ -118,8 +126,15 @@ check_forbidden_additions() { # -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ "$1" || res=1 - # svg figures must be included with wildcard extension - # because of png conversion for pdf docs + # refrain from using RTE_LOG_REGISTER for drivers and libs + awk -v FOLDERS='lib drivers' \ + -v EXPRESSIONS='\\' \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Using RTE_LOG_REGISTER, prefer RTE_LOG_REGISTER_(DEFAULT|SUFFIX)' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + + # SVG must be included with wildcard extension to allow conversion awk -v FOLDERS='doc' \ -v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \ -v RET_ON_FAIL=1 \ @@ -199,8 +214,17 @@ check_internal_tags() { # return $res } +check_release_notes() { # + rel_notes_prefix=doc/guides/rel_notes/release_ + IFS=. read year month release < VERSION + current_rel_notes=${rel_notes_prefix}${year}_${month}.rst + + ! grep -e '^--- a/'$rel_notes_prefix -e '^+++ b/'$rel_notes_prefix "$1" | + grep -v $current_rel_notes +} + number=0 -range='origin/master..' +range='origin/main..' quiet=false verbose=false while getopts hn:qr:v ARG ; do @@ -290,6 +314,14 @@ check () { # ret=1 fi + ! $verbose || printf '\nChecking release notes updates:\n' + report=$(check_release_notes "$tmpinput") + if [ $? -ne 0 ] ; then + $headline_printed || print_headline "$3" + printf '%s\n' "$report" + ret=1 + fi + if [ "$tmpinput" != "$1" ]; then rm -f "$tmpinput" trap - INT