X-Git-Url: http://git.droids-corp.org/?a=blobdiff_plain;f=examples%2Fqos_sched%2Fargs.c;h=476a0ee1c005621b1d6afaa14e454a8eb552d803;hb=4f213197efbe9851f6abcf61d853f870356423ea;hp=9dc5f5affef0d90fe63b6fc0b221f336fa549199;hpb=1c1d4d7a923d4804f1926fc5264f9ecdd8977b04;p=dpdk.git diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c old mode 100755 new mode 100644 index 9dc5f5affe..476a0ee1c0 --- a/examples/qos_sched/args.c +++ b/examples/qos_sched/args.c @@ -1,13 +1,13 @@ /*- * BSD LICENSE - * - * Copyright(c) 2010-2013 Intel Corporation. All rights reserved. + * + * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. * All rights reserved. - * + * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: - * + * * * Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * * Redistributions in binary form must reproduce the above copyright @@ -17,7 +17,7 @@ * * Neither the name of Intel Corporation nor the names of its * contributors may be used to endorse or promote products derived * from this software without specific prior written permission. - * + * * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR @@ -68,7 +68,8 @@ static const char usage[] = " multiple pfc can be configured in command line \n" " \n" "Application optional parameters: \n" - " --mst I : master core index (default value is %u) \n" + " --i : run in interactive mode (default value is %u) \n" + " --mst I : master core index (default value is %u) \n" " --rsz \"A, B, C\" : Ring sizes \n" " A = Size (in number of buffer descriptors) of each of the NIC RX \n" " rings read by the I/O RX lcores (default value is %u) \n" @@ -100,7 +101,7 @@ static const char usage[] = static void app_usage(const char *prgname) { - printf(usage, prgname, app_master_core, + printf(usage, prgname, APP_INTERACTIVE_DEFAULT, app_master_core, APP_RX_DESC_DEFAULT, APP_RING_SIZE, APP_TX_DESC_DEFAULT, MAX_PKT_RX_BURST, PKT_ENQUEUE, PKT_DEQUEUE, MAX_PKT_TX_BURST, NB_MBUF, @@ -111,7 +112,7 @@ app_usage(const char *prgname) static inline int str_is(const char *str, const char *is) { - return (strcmp(str, is) == 0); + return strcmp(str, is) == 0; } /* returns core mask used by DPDK */ @@ -122,7 +123,7 @@ app_eal_core_mask(void) uint64_t cm = 0; struct rte_config *cfg = rte_eal_get_configuration(); - for (i = 0; i < RTE_MAX_LCORE; i++) { + for (i = 0; i < APP_MAX_LCORE; i++) { if (cfg->lcore_role[i] == ROLE_RTE) cm |= (1ULL << i); } @@ -141,8 +142,8 @@ app_cpu_core_count(void) char path[PATH_MAX]; uint32_t ncores = 0; - for(i = 0; i < RTE_MAX_LCORE; i++) { - len = rte_snprintf(path, sizeof(path), SYS_CPU_DIR, i); + for (i = 0; i < APP_MAX_LCORE; i++) { + len = snprintf(path, sizeof(path), SYS_CPU_DIR, i); if (len <= 0 || (unsigned)len >= sizeof(path)) continue; @@ -161,7 +162,7 @@ static int app_parse_opt_vals(const char *conf_str, char separator, uint32_t n_vals, uint32_t *opt_vals) { char *string; - uint32_t i, n_tokens; + int i, n_tokens; char *tokens[MAX_OPT_VALUES]; if (conf_str == NULL || opt_vals == NULL || n_vals == 0 || n_vals > MAX_OPT_VALUES) @@ -174,10 +175,12 @@ app_parse_opt_vals(const char *conf_str, char separator, uint32_t n_vals, uint32 n_tokens = rte_strsplit(string, strnlen(string, 32), tokens, n_vals, separator); - for(i = 0; i < n_tokens; i++) { + if (n_tokens > MAX_OPT_VALUES) + return -1; + + for (i = 0; i < n_tokens; i++) opt_vals[i] = (uint32_t)atol(tokens[i]); - } - + free(string); return n_tokens; @@ -190,7 +193,7 @@ app_parse_ring_conf(const char *conf_str) uint32_t vals[3]; ret = app_parse_opt_vals(conf_str, ',', 3, vals); - if (ret != 3) + if (ret != 3) return ret; ring_conf.rx_size = vals[0]; @@ -207,7 +210,7 @@ app_parse_rth_conf(const char *conf_str) uint32_t vals[3]; ret = app_parse_opt_vals(conf_str, ',', 3, vals); - if (ret != 3) + if (ret != 3) return ret; rx_thresh.pthresh = (uint8_t)vals[0]; @@ -224,7 +227,7 @@ app_parse_tth_conf(const char *conf_str) uint32_t vals[3]; ret = app_parse_opt_vals(conf_str, ',', 3, vals); - if (ret != 3) + if (ret != 3) return ret; tx_thresh.pthresh = (uint8_t)vals[0]; @@ -263,17 +266,20 @@ app_parse_flow_conf(const char *conf_str) } if (pconf->rx_port >= RTE_MAX_ETHPORTS) { - RTE_LOG(ERR, APP, "pfc %u: invalid rx port %hu index\n", nb_pfc, pconf->rx_port); + RTE_LOG(ERR, APP, "pfc %u: invalid rx port %"PRIu8" index\n", + nb_pfc, pconf->rx_port); return -1; } if (pconf->tx_port >= RTE_MAX_ETHPORTS) { - RTE_LOG(ERR, APP, "pfc %u: invalid tx port %hu index\n", nb_pfc, pconf->rx_port); + RTE_LOG(ERR, APP, "pfc %u: invalid tx port %"PRIu8" index\n", + nb_pfc, pconf->tx_port); return -1; } mask = 1lu << pconf->rx_port; if (app_used_rx_port_mask & mask) { - RTE_LOG(ERR, APP, "pfc %u: rx port %hu is used already\n", nb_pfc, pconf->rx_port); + RTE_LOG(ERR, APP, "pfc %u: rx port %"PRIu8" is used already\n", + nb_pfc, pconf->rx_port); return -1; } app_used_rx_port_mask |= mask; @@ -281,7 +287,8 @@ app_parse_flow_conf(const char *conf_str) mask = 1lu << pconf->tx_port; if (app_used_tx_port_mask & mask) { - RTE_LOG(ERR, APP, "pfc %u: port %hu is used already\n", nb_pfc, pconf->tx_port); + RTE_LOG(ERR, APP, "pfc %u: port %"PRIu8" is used already\n", + nb_pfc, pconf->tx_port); return -1; } app_used_tx_port_mask |= mask; @@ -319,7 +326,7 @@ app_parse_burst_conf(const char *conf_str) return 0; } -/* +/* * Parses the argument given in the command line of the application, * calculates mask for used cores and initializes EAL with calculated core mask */ @@ -355,10 +362,14 @@ app_parse_args(int argc, char **argv) /* set en_US locale to print big numbers with ',' */ setlocale(LC_NUMERIC, "en_US.utf-8"); - while ((opt = getopt_long(argc, argv, "", + while ((opt = getopt_long(argc, argv, "i", lgopts, &option_index)) != EOF) { switch (opt) { + case 'i': + printf("Interactive-mode selected\n"); + interactive = 1; + break; /* long options */ case 0: optname = lgopts[option_index].name; @@ -474,4 +485,3 @@ app_parse_args(int argc, char **argv) return 0; } -