From: Gaetan Rivet Date: Wed, 26 Jul 2017 13:35:53 +0000 (+0200) Subject: ethdev: remove useless check in detach capability X-Git-Tag: spdx-start~2334 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;ds=sidebyside;h=8e04becc9432d15531e0596118443d099bc6917a;p=dpdk.git ethdev: remove useless check in detach capability This capability is not bound to which driver is handling the device, but whether the bus is able to unplug it. This check is already performed in rte_eal_dev_detach, there is no need to do it in the ethdev layer. Signed-off-by: Gaetan Rivet Acked-by: Adrien Mazarguil --- diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 8c365ed64c..805ef639c1 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -367,16 +367,6 @@ rte_eth_dev_is_detachable(uint8_t port_id) RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); - switch (rte_eth_devices[port_id].data->kdrv) { - case RTE_KDRV_IGB_UIO: - case RTE_KDRV_UIO_GENERIC: - case RTE_KDRV_NIC_UIO: - case RTE_KDRV_NONE: - case RTE_KDRV_VFIO: - break; - default: - return -ENOTSUP; - } dev_flags = rte_eth_devices[port_id].data->dev_flags; if ((dev_flags & RTE_ETH_DEV_DETACHABLE) && (!(dev_flags & RTE_ETH_DEV_BONDED_SLAVE)))