From: Qiming Yang Date: Fri, 30 Nov 2018 09:05:58 +0000 (+0800) Subject: net/i40e: fix getting RSS configuration X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;ds=sidebyside;h=e5584414817f3fb79655d38c728b675e4fcc1db4;p=dpdk.git net/i40e: fix getting RSS configuration RSS hash configure get API (i40e_dev_rss_hash_conf_get()) didn't check the return value of i40e_get_rss_key(). i40e_dev_rss_hash_conf_get() will return success even getting RSS hash key failed. This patch fixes the issue. Fixes: d0a349409bd7 ("i40e: support AQ based RSS config") Cc: stable@dpdk.org Signed-off-by: Qiming Yang Reviewed-by: Ferruh Yigit --- diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 7030eb1fa6..552a7a566d 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -7459,9 +7459,12 @@ i40e_dev_rss_hash_conf_get(struct rte_eth_dev *dev, struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); uint64_t hena; + int ret; - i40e_get_rss_key(pf->main_vsi, rss_conf->rss_key, + ret = i40e_get_rss_key(pf->main_vsi, rss_conf->rss_key, &rss_conf->rss_key_len); + if (ret) + return ret; hena = (uint64_t)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(0)); hena |= ((uint64_t)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(1))) << 32;