From: Xiaolong Ye Date: Fri, 26 Oct 2018 06:33:14 +0000 (+0800) Subject: net/i40e: fix offload not supported mask X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=09a62d75691fb935c7767d51b750df5910825985;p=dpdk.git net/i40e: fix offload not supported mask Just as the name I40E_TX_OFFLOAD_NOTSUP_MASK indicates, it should be the mask of unsupported features (either not in PKT_TX_OFFLOAD_MASK or in I40E_TX_OFFLOAD_MASK), however, xor will not get desired result here, assume bit 0 of PKT_TX_OFFLOAD_MASK and I40E_TX_OFFLOAD_MAKS are 0 which means corresponding feature is not supported in both sides, then we get value of bit 0 of I40E_TX_OFFLOAD_NOTSUP_MASK which is 0 via xor, it implies that it is supported which doesn't meet our expectation. Correct it by a NOT-AND operation. Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation") Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye Acked-by: Qi Zhang --- diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 8bfa251784..e76412207a 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -69,7 +69,7 @@ I40E_TX_IEEE1588_TMST) #define I40E_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & I40E_TX_OFFLOAD_MASK) static inline void i40e_rxd_to_vlan_tci(struct rte_mbuf *mb, volatile union i40e_rx_desc *rxdp)