From: Igor Russkikh Date: Tue, 12 Mar 2019 15:24:55 +0000 (+0000) Subject: net/atlantic: remove extra checks for error codes X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=0b504bcfefc29fbafd9278603022093df401a85f;p=dpdk.git net/atlantic: remove extra checks for error codes Found by Coverity scan. Checks are useless because at these code places err is always zero. Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations") Cc: stable@dpdk.org Signed-off-by: Igor Russkikh --- diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/atlantic/hw_atl/hw_atl_utils.c index f11093a504..13f02b9f99 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_utils.c +++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.c @@ -462,8 +462,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self, goto err_exit; } } while (sw.tid != fw.tid || 0xFFFFU == fw.len); - if (err < 0) - goto err_exit; if (rpc) { if (fw.len) { @@ -875,8 +873,7 @@ static int aq_fw1x_set_wol(struct aq_hw_s *self, bool wol_enabled, u8 *mac) } err = hw_atl_utils_fw_rpc_call(self, rpc_size); - if (err < 0) - goto err_exit; + err_exit: return err; }