From: Xueming Li Date: Sat, 20 Jan 2018 03:26:31 +0000 (+0800) Subject: cmdline: avoid garbage in unused fields of parsed result X-Git-Tag: spdx-start~7 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=0bf876008f4e51d8c006a3adb3866f0c35c33fbb;p=dpdk.git cmdline: avoid garbage in unused fields of parsed result The result buffer was not initialized before parsing, inducing garbage in unused fields or padding of the parsed structure. Initialize the result buffer each time before parsing. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Xueming Li Acked-by: Olivier Matz --- diff --git a/lib/librte_cmdline/cmdline_parse.c b/lib/librte_cmdline/cmdline_parse.c index c74b146fcc..7f799f94d8 100644 --- a/lib/librte_cmdline/cmdline_parse.c +++ b/lib/librte_cmdline/cmdline_parse.c @@ -168,6 +168,8 @@ match_inst(cmdline_parse_inst_t *inst, const char *buf, int n = 0; struct cmdline_token_hdr token_hdr; + if (resbuf != NULL) + memset(resbuf, 0, resbuf_size); /* check if we match all tokens of inst */ while (!nb_match_token || i < nb_match_token) { token_p = get_token(inst, i);