From: Anatoly Burakov Date: Fri, 25 May 2018 13:39:44 +0000 (+0100) Subject: mem: document callbacks not being supported in some cases X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=0d0ad70175558846d5d5f615e2ad68f761c624d9;p=dpdk.git mem: document callbacks not being supported in some cases Mem event and validator callbacks may not be supported under all circumstances (such as when running in legacy memory mode, or on FreeBSD), and this case needs to be handled by any code that will use these callbacks. Spell this out more clearly, because it's not immediately obvious that this is an expected use case. Signed-off-by: Anatoly Burakov --- diff --git a/lib/librte_eal/common/include/rte_memory.h b/lib/librte_eal/common/include/rte_memory.h index 857773ca44..aab9f6fe59 100644 --- a/lib/librte_eal/common/include/rte_memory.h +++ b/lib/librte_eal/common/include/rte_memory.h @@ -339,6 +339,10 @@ typedef void (*rte_mem_event_callback_t)(enum rte_mem_event event_type, * therefore some functions (e.g. `rte_memseg_walk()`) will cause a * deadlock when called from within such callbacks. * + * @note mem event callbacks not being supported is an expected error condition, + * so user code needs to handle this situation. In these cases, return + * value will be -1, and rte_errno will be set to ENOTSUP. + * * @param name * Name associated with specified callback to be added to the list. * @@ -399,6 +403,10 @@ typedef int (*rte_mem_alloc_validator_t)(int socket_id, * therefore some functions (e.g. `rte_memseg_walk()`) will cause a * deadlock when called from within such callbacks. * + * @note validator callbacks not being supported is an expected error condition, + * so user code needs to handle this situation. In these cases, return + * value will be -1, and rte_errno will be set to ENOTSUP. + * * @param name * Name associated with specified callback to be added to the list. *