From: Ferruh Yigit Date: Wed, 20 May 2020 10:22:22 +0000 (+0100) Subject: bus/fslmc: drop inline from non-static functions X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=0ff708ed6f615cf3272c76f74987834fa6485fd0;p=dpdk.git bus/fslmc: drop inline from non-static functions There is no point in having non-static (and non-extern) inline functions. Also this breaks the build for the ICC [1] because of the 'internal' symbol check. When function is 'inline' ICC is ignoring 'section' attribute and not putting function to 'internal' section which breaks 'check-symbols.sh' script with below error. [1] qbman_swp_dqrr_next is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_dqrr_next qbman_swp_enqueue_multiple is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_enqueue_multiple qbman_swp_enqueue_multiple_desc is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_enqueue_multiple_desc qbman_swp_enqueue_multiple_fd is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_enqueue_multiple_fd qbman_swp_pull is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_pull qbman_swp_release is not flagged as internal but is listed in version map Please add __rte_internal to the definition of qbman_swp_release Signed-off-by: Ferruh Yigit Acked-by: Hemant Agrawal --- diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c index d4223bdc8b..d7ff74c7a2 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.c +++ b/drivers/bus/fslmc/qbman/qbman_portal.c @@ -1019,7 +1019,7 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s, return num_enqueued; } -inline int qbman_swp_enqueue_multiple(struct qbman_swp *s, +int qbman_swp_enqueue_multiple(struct qbman_swp *s, const struct qbman_eq_desc *d, const struct qbman_fd *fd, uint32_t *flags, @@ -1227,7 +1227,7 @@ static int qbman_swp_enqueue_multiple_fd_mem_back(struct qbman_swp *s, return num_enqueued; } -inline int qbman_swp_enqueue_multiple_fd(struct qbman_swp *s, +int qbman_swp_enqueue_multiple_fd(struct qbman_swp *s, const struct qbman_eq_desc *d, struct qbman_fd **fd, uint32_t *flags, @@ -1421,7 +1421,7 @@ static int qbman_swp_enqueue_multiple_desc_mem_back(struct qbman_swp *s, return num_enqueued; } -inline int qbman_swp_enqueue_multiple_desc(struct qbman_swp *s, +int qbman_swp_enqueue_multiple_desc(struct qbman_swp *s, const struct qbman_eq_desc *d, const struct qbman_fd *fd, int num_frames) @@ -1599,7 +1599,7 @@ static int qbman_swp_pull_mem_back(struct qbman_swp *s, return 0; } -inline int qbman_swp_pull(struct qbman_swp *s, struct qbman_pull_desc *d) +int qbman_swp_pull(struct qbman_swp *s, struct qbman_pull_desc *d) { return qbman_swp_pull_ptr(s, d); } @@ -1636,7 +1636,7 @@ void qbman_swp_prefetch_dqrr_next(struct qbman_swp *s) * only once, so repeated calls can return a sequence of DQRR entries, without * requiring they be consumed immediately or in any particular order. */ -inline const struct qbman_result *qbman_swp_dqrr_next(struct qbman_swp *s) +const struct qbman_result *qbman_swp_dqrr_next(struct qbman_swp *s) { return qbman_swp_dqrr_next_ptr(s); } @@ -2129,7 +2129,7 @@ static int qbman_swp_release_mem_back(struct qbman_swp *s, return 0; } -inline int qbman_swp_release(struct qbman_swp *s, +int qbman_swp_release(struct qbman_swp *s, const struct qbman_release_desc *d, const uint64_t *buffers, unsigned int num_buffers)