From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 14 Apr 2022 20:01:04 +0000 (-0700)
Subject: rib: fix traversal with /32 route
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=1b984e98a3fd00e607ec14b8b9299a2f14698dc3;p=dpdk.git

rib: fix traversal with /32 route

If a /32 route is entered in the RIB the code to traverse
will not see end of the tree. This is due to trying
to do a negative shift which is an undefined in C.

Fix by checking for max depth as is already done in rib6.

Fixes: 5a5793a5ffa2 ("rib: add RIB library")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---

diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c
index cd9e823068..0603980cab 100644
--- a/lib/rib/rte_rib.c
+++ b/lib/rib/rte_rib.c
@@ -71,6 +71,8 @@ is_covered(uint32_t ip1, uint32_t ip2, uint8_t depth)
 static inline struct rte_rib_node *
 get_nxt_node(struct rte_rib_node *node, uint32_t ip)
 {
+	if (node->depth == RIB_MAXDEPTH)
+		return NULL;
 	return (ip & (1 << (31 - node->depth))) ? node->right : node->left;
 }