From: Tiwei Bie Date: Tue, 13 Aug 2019 02:07:25 +0000 (+0800) Subject: net/virtio: remove remaining simple Tx related stuff X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=1d2aa48b876148715680c9a1d69c195a929bad14;p=dpdk.git net/virtio: remove remaining simple Tx related stuff The simple Tx path in virtio has been removed in below commit. This patch removes an undefined function declaration of simple Tx and all related descriptions in the doc. Fixes: 57f818963d80 ("net/virtio: remove simple Tx path") Cc: stable@dpdk.org Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 2ae875cb49..da9cd6ba64 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -201,7 +201,7 @@ The packet transmission flow is: Virtio PMD Rx/Tx Callbacks -------------------------- -Virtio driver has 4 Rx callbacks and 3 Tx callbacks. +Virtio driver has 4 Rx callbacks and 2 Tx callbacks. Rx callbacks: @@ -223,9 +223,6 @@ Tx callbacks: #. ``virtio_xmit_pkts``: Regular version. -#. ``virtio_xmit_pkts_simple``: - Vector version fixes the available ring indexes to optimize performance. - #. ``virtio_xmit_pkts_inorder``: In-order version. @@ -239,25 +236,17 @@ By default, the non-vector callbacks are used: Vector callbacks will be used when: -* ``txmode.offloads`` is set to ``0x0``, which implies: - - * Single segment is specified. - - * No offload support is needed. - * Mergeable Rx buffers is disabled. The corresponding callbacks are: * For Rx: ``virtio_recv_pkts_vec``. -* For Tx: ``virtio_xmit_pkts_simple``. - Example of using the vector version of the virtio poll mode driver in ``testpmd``:: - testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 --nb-cores=1 + testpmd -l 0-2 -n 4 -- -i --rxq=1 --txq=1 --nb-cores=1 In-order callbacks only work on simulated virtio user vdev. diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 20d331795a..a10111758d 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++ b/drivers/net/virtio/virtio_ethdev.h @@ -103,9 +103,6 @@ uint16_t virtio_xmit_pkts_inorder(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts); -uint16_t virtio_xmit_pkts_simple(void *tx_queue, struct rte_mbuf **tx_pkts, - uint16_t nb_pkts); - int eth_virtio_dev_init(struct rte_eth_dev *eth_dev); void virtio_interrupt_handler(void *param);