From: Michael Santana <msantana@redhat.com>
Date: Mon, 4 Mar 2019 19:07:16 +0000 (-0500)
Subject: devtools: fix result of svg include check
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=1f6168503e882a37efbc8746e42c8af01a342405;p=dpdk.git

devtools: fix result of svg include check

Fix trivial bug. In sh shell, 'foo = 1' is not the same as
'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo
as a command, rather than a simple variable assignment.

Fixes: dafc04c15174 ("devtools: fix return of forbidden addition checks")
Cc: stable@dpdk.org

Signed-off-by: Michael Santana <msantana@redhat.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
---

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 2cf2404ba0..3272774644 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -73,7 +73,7 @@ check_forbidden_additions() { # <patch>
 		-v RET_ON_FAIL=1 \
 		-v MESSAGE='Using explicit .svg extension instead of .*' \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
-		"$1" || res = 1
+		"$1" || res=1
 
 	return $res
 }