From: Shijith Thotton <shijith.thotton@caviumnetworks.com>
Date: Mon, 10 Apr 2017 07:18:56 +0000 (+0530)
Subject: net/liquidio: fix null pointer check
X-Git-Tag: spdx-start~3615
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=21ea96388eef6f33bd3f0cbfea1554c394ada4d8;p=dpdk.git

net/liquidio: fix null pointer check

Fix null pointer check in release Rx/Tx queue APIs.

Coverity issue: 1423923
Coverity issue: 1423924
Fixes: 9a30013b9884 ("net/liquidio: add API to release Rx queue")
Fixes: cf6bfcbea178 ("net/liquidio: add API to release Tx queue")

Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
---

diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
index 4edb0d1fba..0c78afbc20 100644
--- a/drivers/net/liquidio/lio_ethdev.c
+++ b/drivers/net/liquidio/lio_ethdev.c
@@ -1156,14 +1156,13 @@ void
 lio_dev_rx_queue_release(void *rxq)
 {
 	struct lio_droq *droq = rxq;
-	struct lio_device *lio_dev = droq->lio_dev;
 	int oq_no;
 
-	/* Run time queue deletion not supported */
-	if (lio_dev->port_configured)
-		return;
+	if (droq) {
+		/* Run time queue deletion not supported */
+		if (droq->lio_dev->port_configured)
+			return;
 
-	if (droq != NULL) {
 		oq_no = droq->q_no;
 		lio_delete_droq_queue(droq->lio_dev, oq_no);
 	}
@@ -1251,14 +1250,14 @@ void
 lio_dev_tx_queue_release(void *txq)
 {
 	struct lio_instr_queue *tq = txq;
-	struct lio_device *lio_dev = tq->lio_dev;
 	uint32_t fw_mapped_iq_no;
 
-	/* Run time queue deletion not supported */
-	if (lio_dev->port_configured)
-		return;
 
-	if (tq != NULL) {
+	if (tq) {
+		/* Run time queue deletion not supported */
+		if (tq->lio_dev->port_configured)
+			return;
+
 		/* Free sg_list */
 		lio_delete_sglist(tq);