From: Gowrishankar Muthukrishnan Date: Sat, 12 Feb 2022 12:38:19 +0000 (+0530) Subject: common/cnxk fix unintended sign extension X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=2447b0b6695d4cecb8606d4c069564f35c31b1d4;p=dpdk.git common/cnxk fix unintended sign extension This patch fixes unintended sign extensions reported in coverity scan. Coverity issue: 373258 Fixes: 8ca851cdc598 ("common/cnxk: support dual VLAN insert and strip actions") Cc: stable@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Jerin Jacob --- diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c index df3016f538..245eb8b74f 100644 --- a/drivers/common/cnxk/roc_npc.c +++ b/drivers/common/cnxk/roc_npc.c @@ -969,14 +969,14 @@ npc_vtag_insert_action_configure(struct mbox *mbox, struct roc_npc_flow *flow, vtag_cfg->cfg_type = VTAG_TX; vtag_cfg->vtag_size = NIX_VTAGSIZE_T4; vtag_cfg->tx.vtag0 = - ((vlan_info[0].vlan_ethtype << 16) | + (((uint32_t)vlan_info[0].vlan_ethtype << 16) | (vlan_info[0].vlan_pcp << 13) | vlan_info[0].vlan_id); vtag_cfg->tx.cfg_vtag0 = 1; if (flow->vtag_insert_count == 2) { vtag_cfg->tx.vtag1 = - ((vlan_info[1].vlan_ethtype << 16) | + (((uint32_t)vlan_info[1].vlan_ethtype << 16) | (vlan_info[1].vlan_pcp << 13) | vlan_info[1].vlan_id); vtag_cfg->tx.cfg_vtag1 = 1;