From: Ivan Malov Date: Tue, 8 Feb 2022 23:26:48 +0000 (+0300) Subject: net/sfc: demand Tx fast free offload on EF10 simple datapath X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=24a491bb882a3269b9b4e2754e1d5b43d83b9821;p=dpdk.git net/sfc: demand Tx fast free offload on EF10 simple datapath Enforce this offload as it is immutable on the said datapath. Fixes: c78d280e88ef ("net/sfc: convert to new Tx offload API") Cc: stable@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- diff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c index cd927cf2f7..f376f24f7b 100644 --- a/drivers/net/sfc/sfc_tx.c +++ b/drivers/net/sfc/sfc_tx.c @@ -308,6 +308,7 @@ sfc_tx_qinit_info(struct sfc_adapter *sa, sfc_sw_index_t sw_index) static int sfc_tx_check_mode(struct sfc_adapter *sa, const struct rte_eth_txmode *txmode) { + uint64_t dev_tx_offload_cap = sfc_tx_get_dev_offload_caps(sa); int rc = 0; switch (txmode->mq_mode) { @@ -319,6 +320,13 @@ sfc_tx_check_mode(struct sfc_adapter *sa, const struct rte_eth_txmode *txmode) rc = EINVAL; } + if ((dev_tx_offload_cap & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) != 0 && + (txmode->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) == 0) { + sfc_err(sa, "There is no FAST_FREE flag in the attempted Tx mode configuration"); + sfc_err(sa, "FAST_FREE is always active as per the current Tx datapath variant"); + rc = EINVAL; + } + /* * These features are claimed to be i40e-specific, * but it does make sense to double-check their absence