From: Kalesh AP Date: Thu, 28 Oct 2021 02:29:44 +0000 (+0530) Subject: net/bnxt: fix flow RSS failure handling X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=26ba9e7b918072474ed9f70ad6c1b6c027d39791;p=dpdk.git net/bnxt: fix flow RSS failure handling With commit 239695f754cb ("net/bnxt: enhance RSS action support"), when bnxt_hwrm_vnic_rss_cfg() call fails, driver was not setting flow error using "rte_flow_error_set". Fixes: 239695f754cb ("net/bnxt: enhance RSS action support") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index 09b1342533..d062be5525 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -1226,6 +1226,15 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp, skip_rss_table: rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); + if (rc != 0) { + rte_flow_error_set(error, + -rc, + RTE_FLOW_ERROR_TYPE_ACTION, + act, + "VNIC RSS configure failed"); + rc = -rte_errno; + goto ret; + } ret: return rc; } @@ -1515,7 +1524,7 @@ skip_vnic_alloc: /* RSS config update requested */ rc = bnxt_vnic_rss_cfg_update(bp, vnic, act, error); if (rc != 0) - return -rte_errno; + goto ret; filter->dst_id = vnic->fw_vnic_id; break;