From: Michael Qiu Date: Fri, 29 Jan 2016 05:58:10 +0000 (+0800) Subject: ixgbe: fix disable interrupt twice X-Git-Tag: spdx-start~7410 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=276ddef262f49099dfafeb96791a83240f7d9d66;p=dpdk.git ixgbe: fix disable interrupt twice Currently, ixgbe vf and pf will disable interrupt twice in stop stage and uninit stage. It will cause an error: testpmd> quit Shutting down port 0... Stopping ports... Done Closing ports... EAL: Error disabling MSI-X interrupts for fd 26 Done because the interrupt has already been disabled in stop stage. Since it is enabled in init stage, better remove from stop stage. Fixes: 0eb609239efd ("ixgbe: enable Rx queue interrupts for PF and VF") Signed-off-by: Michael Qiu Acked-by: Wenzhuo Lu Acked-by: Helin Zhang --- diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 9a392b9d32..b6f82e0d98 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2248,9 +2248,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev) /* disable interrupts */ ixgbe_disable_intr(hw); - /* disable intr eventfd mapping */ - rte_intr_disable(intr_handle); - /* reset the NIC */ ixgbe_pf_reset_hw(hw); hw->adapter_stopped = 0; @@ -3962,9 +3959,6 @@ ixgbevf_dev_stop(struct rte_eth_dev *dev) ixgbe_dev_clear_queues(dev); - /* disable intr eventfd mapping */ - rte_intr_disable(intr_handle); - /* Clean datapath event and queue/vec mapping */ rte_intr_efd_disable(intr_handle); if (intr_handle->intr_vec != NULL) {