From: Cunming Liang Date: Thu, 26 Jun 2014 06:53:32 +0000 (+0800) Subject: ixgbe: prefer enabling olflags rather than not disabling X-Git-Tag: spdx-start~10597 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=359f106a69a9;p=dpdk.git ixgbe: prefer enabling olflags rather than not disabling RTE_IXGBE_RX_OLFLAGS_ENABLE gives a hint whick keeping packet type in RX ol_flags or not. By default it is set to update ol_flags in RX mbuf header. If unset it, will gain addtional performance, but will lose packet type information. Signed-off-by: Cunming Liang Acked-by: Bruce Richardson Acked-by: Yong Liu Tested-by: Zhaochen Zhan --- diff --git a/config/common_linuxapp b/config/common_linuxapp index 5b896c3afb..b19c4d943d 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -192,7 +192,7 @@ CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n CONFIG_RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC=y CONFIG_RTE_LIBRTE_IXGBE_ALLOW_UNSUPPORTED_SFP=n CONFIG_RTE_IXGBE_INC_VECTOR=y -CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=n +CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y # # Compile burst-oriented I40E PMD driver diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c index 74d1b3602f..09e19a34e8 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c @@ -145,7 +145,7 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq) * gives improved performance, at the cost of losing the offload info * in the received packet */ -#ifndef RTE_IXGBE_RX_OLFLAGS_DISABLE +#ifdef RTE_IXGBE_RX_OLFLAGS_ENABLE #define OLFLAGS_MASK ((uint16_t)(PKT_RX_VLAN_PKT | PKT_RX_IPV4_HDR |\ PKT_RX_IPV4_HDR_EXT | PKT_RX_IPV6_HDR |\ @@ -679,7 +679,7 @@ int ixgbe_rx_vec_condition_check(struct rte_eth_dev *dev) struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; struct rte_fdir_conf *fconf = &dev->data->dev_conf.fdir_conf; -#ifdef RTE_IXGBE_RX_OLFLAGS_DISABLE +#ifndef RTE_IXGBE_RX_OLFLAGS_ENABLE /* whithout rx ol_flags, no VP flag report */ if (rxmode->hw_vlan_strip != 0 || rxmode->hw_vlan_extend != 0)