From: John Daley <johndale@cisco.com>
Date: Mon, 14 Feb 2022 20:46:10 +0000 (-0800)
Subject: net/enic: fix dereference before null check
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=3f326c460ff09146917d6a060cf5715a1b8b6446;p=dpdk.git

net/enic: fix dereference before null check

This patch fixes an issue found by coverity. It checks for a possible
null value of "error" before dereferencing it.

CID: 375064: Dereference after null check
Either the check against null is unnecessary, or there may be a null
pointer dereference.

Coverity issue: 375064
Fixes: ee806eea59fe ("net/enic: support GENEVE flow item")

Signed-off-by: John Daley <johndale@cisco.com>
Reviewed-by: Hyong Youb Kim <hyonkim@cisco.com>
---

diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c
index f0bda19a70..c87d3af847 100644
--- a/drivers/net/enic/enic_fm_flow.c
+++ b/drivers/net/enic/enic_fm_flow.c
@@ -1204,7 +1204,7 @@ enic_fm_copy_entry(struct enic_flowman *fm,
 		ret = item_info->copy_item(&args);
 		if (ret) {
 			/* If copy_item set the error, return that */
-			if (error->type != RTE_FLOW_ERROR_TYPE_NONE)
+			if (error && error->type != RTE_FLOW_ERROR_TYPE_NONE)
 				return ret;
 			goto item_not_supported;
 		}