From: Matan Azrad <matan@mellanox.com>
Date: Tue, 12 Nov 2019 08:47:39 +0000 (+0000)
Subject: app/testpmd: fix invalid port detaching
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=43d0e304980a;p=dpdk.git

app/testpmd: fix invalid port detaching

The port was not validated before detaching.

Ignore port detach operation when the port is not valid.

Fixes: f8e5baa2662d ("app/testpmd: check not detaching device twice")
Cc: stable@dpdk.org

Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
---

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 446da36234..73ebf37aae 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2557,6 +2557,9 @@ detach_port_device(portid_t port_id)
 
 	printf("Removing a device...\n");
 
+	if (port_id_is_invalid(port_id, ENABLED_WARN))
+		return;
+
 	dev = rte_eth_devices[port_id].device;
 	if (dev == NULL) {
 		printf("Device already removed\n");