From: Stephen Hemminger <sthemmin@microsoft.com>
Date: Thu, 14 Dec 2017 23:32:18 +0000 (-0800)
Subject: kni: remove redundant parenthesis
X-Git-Tag: spdx-start~775
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=4d4cc68f0d8060ff449b19e006b27771773e844b;p=dpdk.git

kni: remove redundant parenthesis

Don't need parens on simple if expression

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---

diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c
index e0f427a303..30c2d6ce8e 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c
+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c
@@ -3009,7 +3009,7 @@ static int __devinit igb_probe(struct pci_dev *pdev,
 		case e1000_i211:
 			/* Enable EEE for internal copper PHY devices */
 			err = e1000_set_eee_i350(hw);
-			if ((!err) &&
+			if (!err &&
 			    (adapter->flags & IGB_FLAG_EEE))
 				adapter->eee_advert =
 					MDIO_EEE_100TX | MDIO_EEE_1000T;
@@ -5022,7 +5022,7 @@ static void igb_update_itr(struct igb_q_vector *q_vector,
 				itrval = bulk_latency;
 			} else if ((packets < 10) || ((bytes/packets) > 1200)) {
 				itrval = bulk_latency;
-			} else if ((packets > 35)) {
+			} else if (packets > 35) {
 				itrval = lowest_latency;
 			}
 		} else if (bytes/packets > 2000) {
diff --git a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_common.c b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_common.c
index 2c861de5d6..1a1cfe574c 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_common.c
+++ b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_common.c
@@ -2415,7 +2415,7 @@ out:
 static s32 ixgbe_negotiate_fc(struct ixgbe_hw *hw, u32 adv_reg, u32 lp_reg,
 			      u32 adv_sym, u32 adv_asm, u32 lp_sym, u32 lp_asm)
 {
-	if ((!(adv_reg)) ||  (!(lp_reg)))
+	if (!adv_reg || !lp_reg)
 		return IXGBE_ERR_FC_NOT_NEGOTIATED;
 
 	if ((adv_reg & adv_sym) && (lp_reg & lp_sym)) {
@@ -3279,7 +3279,7 @@ s32 ixgbe_set_vfta_generic(struct ixgbe_hw *hw, u32 vlan, u32 vind,
 			vfta_changed = true;
 		}
 	} else {
-		if ((vfta & targetbit)) {
+		if (vfta & targetbit) {
 			vfta &= ~targetbit;
 			vfta_changed = true;
 		}
@@ -3392,7 +3392,7 @@ s32 ixgbe_set_vlvf_generic(struct ixgbe_hw *hw, u32 vlan, u32 vind,
 		if (bits) {
 			IXGBE_WRITE_REG(hw, IXGBE_VLVF(vlvf_index),
 					(IXGBE_VLVF_VIEN | vlan));
-			if ((!vlan_on) && (vfta_changed != NULL)) {
+			if (!vlan_on && (vfta_changed != NULL)) {
 				/* someone wants to clear the vfta entry
 				 * but some pools/VFs are still using it.
 				 * Ignore it. */