From: Pawel Wodkowski Date: Wed, 25 Feb 2015 12:41:23 +0000 (+0100) Subject: timer: fix callback declaration inconsistency X-Git-Tag: spdx-start~9501 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=5663c25dcceb744b980ff28df5687de7ec8cbbf8;p=dpdk.git timer: fix callback declaration inconsistency This patch remove inconsistency between declaration of type rte_timer_cb_t, field f in struct rte_timer and function __rte_timer_reset(). Although compiler treat both of them the same, the static analysis tool like complain about that. Signed-off-by: Pawel Wodkowski Acked-by: Olivier Matz --- diff --git a/lib/librte_timer/rte_timer.h b/lib/librte_timer/rte_timer.h index 35b8719fde..77547c6b8f 100644 --- a/lib/librte_timer/rte_timer.h +++ b/lib/librte_timer/rte_timer.h @@ -115,7 +115,7 @@ struct rte_timer; /** * Callback function type for timer expiry. */ -typedef void (rte_timer_cb_t)(struct rte_timer *, void *); +typedef void (*rte_timer_cb_t)(struct rte_timer *, void *); #define MAX_SKIPLIST_DEPTH 10 @@ -128,7 +128,7 @@ struct rte_timer struct rte_timer *sl_next[MAX_SKIPLIST_DEPTH]; volatile union rte_timer_status status; /**< Status of timer. */ uint64_t period; /**< Period of timer (0 if not periodic). */ - rte_timer_cb_t *f; /**< Callback function. */ + rte_timer_cb_t f; /**< Callback function. */ void *arg; /**< Argument to callback function. */ };