From: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Date: Mon, 11 May 2020 09:22:32 +0000 (+0100)
Subject: app/fib: fix parsing of invalid line
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=5876077aba8c1bf8a46f08ae27b880e3f7f8550f;p=dpdk.git

app/fib: fix parsing of invalid line

Check returned value after strtok()
CID 355674 (#1 of 1): Dereference null return value (NULL_RETURNS)
4. dereference: Dereferencing a pointer that might be NULL s when
calling inet_pton

Fixes: 103809d032cd ("app/test-fib: add test application for FIB")
Cc: stable@dpdk.org

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---

diff --git a/app/test-fib/main.c b/app/test-fib/main.c
index 6e80d65f4c..9cf01b16e5 100644
--- a/app/test-fib/main.c
+++ b/app/test-fib/main.c
@@ -543,6 +543,8 @@ parse_lookup(FILE *f, int af)
 
 	while (fgets(line, sizeof(line), f) != NULL) {
 		s = strtok(line, " \t\n");
+		if (s == NULL)
+			return -EINVAL;
 		ret = inet_pton(af, s, &tbl[i]);
 		if (ret != 1)
 			return -EINVAL;