From: Haiyue Wang Date: Thu, 12 Nov 2020 02:00:06 +0000 (+0800) Subject: net/ixgbe: remove redundant MAC flag check X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=5db5d3b72e7cd5c6c986ef72924eb9069c842063;p=dpdk.git net/ixgbe: remove redundant MAC flag check The flag of RTE_ETHTYPE_FLAGS_MAC has been checked twice, so remove the first error message "Not supported by ethertype filter" which is not so specific, and keep the error message "mac compare is unsupported" which aligns to the definition of RTE_ETHTYPE_FLAGS_MAC. Fixes: eb3539fc8550 ("net/ixgbe: parse ethertype filter") Cc: stable@dpdk.org Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index dff04c462c..39f6ed73f6 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -870,15 +870,6 @@ ixgbe_parse_ethertype_filter(struct rte_eth_dev *dev, if (ret) return ret; - /* Ixgbe doesn't support MAC address. */ - if (filter->flags & RTE_ETHTYPE_FLAGS_MAC) { - memset(filter, 0, sizeof(struct rte_eth_ethertype_filter)); - rte_flow_error_set(error, EINVAL, - RTE_FLOW_ERROR_TYPE_ITEM, - NULL, "Not supported by ethertype filter"); - return -rte_errno; - } - if (filter->queue >= dev->data->nb_rx_queues) { memset(filter, 0, sizeof(struct rte_eth_ethertype_filter)); rte_flow_error_set(error, EINVAL,