From: Nélio Laranjeiro Date: Wed, 25 Oct 2017 14:04:36 +0000 (+0200) Subject: net/mlx5: fix device stop with multiple regions X-Git-Tag: spdx-start~1086 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=5f64e6bfa1937828c9813af777a85ea57cc2e4fe;p=dpdk.git net/mlx5: fix device stop with multiple regions LIST macro are not safe when inside a LIST_FOREACH() a LIST_REMOVE() is called to remove an entry, this behavior is undefined causing some entries to disappear from the list. Fixes: 6e78005a9b30 ("net/mlx5: add reference counter on DPDK Tx queues") Signed-off-by: Nelio Laranjeiro --- diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index 982d0a24db..5de2d026e1 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -188,7 +188,7 @@ mlx5_dev_start(struct rte_eth_dev *dev) error: /* Rollback. */ dev->data->dev_started = 0; - LIST_FOREACH(mr, &priv->mr, next) + for (mr = LIST_FIRST(&priv->mr); mr; mr = LIST_FIRST(&priv->mr)) priv_mr_release(priv, mr); priv_flow_stop(priv, &priv->flows); priv_dev_traffic_disable(priv, dev); @@ -230,9 +230,8 @@ mlx5_dev_stop(struct rte_eth_dev *dev) priv_dev_interrupt_handler_uninstall(priv, dev); priv_txq_stop(priv); priv_rxq_stop(priv); - LIST_FOREACH(mr, &priv->mr, next) { + for (mr = LIST_FIRST(&priv->mr); mr; mr = LIST_FIRST(&priv->mr)) priv_mr_release(priv, mr); - } priv_flow_delete_drop_queue(priv); priv_unlock(priv); }