From: Jacek Piasecki Date: Wed, 25 Oct 2017 10:07:18 +0000 (+0200) Subject: examples/vhost_scsi: fix product id string termination X-Git-Tag: spdx-start~1229 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=681459bf9cd5778ada011e6d8d681436ec5394f0;p=dpdk.git examples/vhost_scsi: fix product id string termination Use snprintf instead strncpy to get safe null string termination. There was possible to get not terminated string after strncpy operation. Coverity issue: 158631 Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app") Cc: stable@dpdk.org Signed-off-by: Jacek Piasecki Acked-by: Maxime Coquelin --- diff --git a/examples/vhost_scsi/scsi.c b/examples/vhost_scsi/scsi.c index 54d3104ed5..fd430ec23b 100644 --- a/examples/vhost_scsi/scsi.c +++ b/examples/vhost_scsi/scsi.c @@ -307,7 +307,9 @@ vhost_bdev_scsi_inquiry_command(struct vhost_block_dev *bdev, strncpy((char *)inqdata->t10_vendor_id, "INTEL", 8); /* PRODUCT IDENTIFICATION */ - strncpy((char *)inqdata->product_id, bdev->product_name, 16); + snprintf((char *)inqdata->product_id, + RTE_DIM(inqdata->product_id), "%s", + bdev->product_name); /* PRODUCT REVISION LEVEL */ strncpy((char *)inqdata->product_rev, "0001", 4);