From: Wenzhuo Lu Date: Wed, 24 Jun 2015 03:26:04 +0000 (+0800) Subject: ixgbe/base: release X540 semaphores in proper order X-Git-Tag: spdx-start~8961 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=69651bbfcbebf9a1fb9467532b7fe310d66bca0e;p=dpdk.git ixgbe/base: release X540 semaphores in proper order Because we acquire two semaphore bits before setting the SWFW_SYNC register, we should release them in the reverse order that they were acquired. Signed-off-by: Wenzhuo Lu Acked-by: Helin Zhang --- diff --git a/drivers/net/ixgbe/base/ixgbe_x540.c b/drivers/net/ixgbe/base/ixgbe_x540.c index af29b13baf..4891702907 100644 --- a/drivers/net/ixgbe/base/ixgbe_x540.c +++ b/drivers/net/ixgbe/base/ixgbe_x540.c @@ -931,14 +931,14 @@ STATIC void ixgbe_release_swfw_sync_semaphore(struct ixgbe_hw *hw) /* Release both semaphores by writing 0 to the bits REGSMP and SMBI */ - swsm = IXGBE_READ_REG(hw, IXGBE_SWSM); - swsm &= ~IXGBE_SWSM_SMBI; - IXGBE_WRITE_REG(hw, IXGBE_SWSM, swsm); - swsm = IXGBE_READ_REG(hw, IXGBE_SWFW_SYNC); swsm &= ~IXGBE_SWFW_REGSMP; IXGBE_WRITE_REG(hw, IXGBE_SWFW_SYNC, swsm); + swsm = IXGBE_READ_REG(hw, IXGBE_SWSM); + swsm &= ~IXGBE_SWSM_SMBI; + IXGBE_WRITE_REG(hw, IXGBE_SWSM, swsm); + IXGBE_WRITE_FLUSH(hw); }