From: Maxime Coquelin Date: Fri, 12 Oct 2018 12:40:31 +0000 (+0200) Subject: vhost: clarify reply-ack in case a reply was already sent X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=7987eb1bc7e28884ac91942d7ad9e51bde15cebd;p=dpdk.git vhost: clarify reply-ack in case a reply was already sent For messages that require a reply, a second ack should not be sent when reply-ack protocol feature is negotiated, even if the corresponding flag is set in the message. The code is compliant with the spec but it isn't clear it is, so this patch adds a comment to make it explicit. Suggested-by: Ilya Maximets Signed-off-by: Maxime Coquelin Acked-by: Ilya Maximets Reviewed-by: Tiwei Bie --- diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 09a90a20b2..a7729990df 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -1783,6 +1783,11 @@ skip_to_reply: if (unlock_required) vhost_user_unlock_all_queue_pairs(dev); + /* + * If the request required a reply that was already sent, + * this optional reply-ack won't be sent as the + * VHOST_USER_NEED_REPLY was cleared in send_vhost_reply(). + */ if (msg.flags & VHOST_USER_NEED_REPLY) { msg.payload.u64 = ret == VH_RESULT_ERR; msg.size = sizeof(msg.payload.u64);