From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Date: Mon, 17 Apr 2017 07:27:04 +0000 (+0800)
Subject: vhost: fix use after free
X-Git-Tag: spdx-start~3502
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=7bd841b2691a428ac70f965a6ee352728da9c0f3;p=dpdk.git

vhost: fix use after free

A "return" is missing on error, which could lead to a "use after free"
issue (about var "conn").

Coverity issue: 143476
Fixes: 65388b43f592 ("vhost: fix fd leaks for vhost-user server mode")

Reported-by: John McNamara <john.mcnamara@intel.com>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---

diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
index 66fd335c88..c7f99b08fd 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -242,6 +242,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket *vsocket)
 		RTE_LOG(ERR, VHOST_CONFIG,
 			"failed to add fd %d into vhost server fdset\n",
 			fd);
+		return;
 	}
 
 	pthread_mutex_lock(&vsocket->conn_mutex);