From: Shahaf Shuler Date: Tue, 1 May 2018 09:58:48 +0000 (+0300) Subject: net/mlx5: fix ethtool link setting call order X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=7d2e32f76cfc;p=dpdk.git net/mlx5: fix ethtool link setting call order According to ethtool_link_setting API recommendation ETHTOOL_GLINKSETTINGS should be called before ETHTOOL_GSET as the later one deprecated. Fixes: f47ba80080ab ("net/mlx5: remove kernel version check") Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 746b94f734..588d4ba627 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -697,9 +697,9 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) time_t start_time = time(NULL); do { - ret = mlx5_link_update_unlocked_gset(dev, &dev_link); + ret = mlx5_link_update_unlocked_gs(dev, &dev_link); if (ret) - ret = mlx5_link_update_unlocked_gs(dev, &dev_link); + ret = mlx5_link_update_unlocked_gset(dev, &dev_link); if (ret == 0) break; /* Handle wait to complete situation. */