From: Pablo de Lara Date: Mon, 31 Aug 2015 13:30:03 +0000 (+0100) Subject: hash: fix memory allocation of cuckoo key table X-Git-Tag: spdx-start~8483 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=7d49e0f4a979206ec8faa2f64c69a771b8c27d14;p=dpdk.git hash: fix memory allocation of cuckoo key table When calculating the size for the table which allocates the keys, size was calculated wrongly from multiplying two 32-bit variables, resulting on a 32-bit number, before casting to 64-bit, so maximum size was 4G. Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation") Signed-off-by: Pablo de Lara --- diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c index 4da859a6b7..70197638b9 100644 --- a/lib/librte_hash/rte_cuckoo_hash.c +++ b/lib/librte_hash/rte_cuckoo_hash.c @@ -238,7 +238,7 @@ rte_hash_create(const struct rte_hash_parameters *params) const uint32_t key_entry_size = sizeof(struct rte_hash_key) + params->key_len; /* Store all keys and leave the first entry as a dummy entry for lookup_bulk */ - const uint64_t key_tbl_size = key_entry_size * (params->entries + 1); + const uint64_t key_tbl_size = (uint64_t) key_entry_size * (params->entries + 1); k = rte_zmalloc_socket(NULL, key_tbl_size, RTE_CACHE_LINE_SIZE, params->socket_id);