From: Harman Kalra Date: Mon, 1 Nov 2021 17:53:33 +0000 (+0530) Subject: eal/linux: check interrupt file descriptor validity X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=7e2083e46251e1645064215dec406923e8dd8d1f;p=dpdk.git eal/linux: check interrupt file descriptor validity This patch fixes coverity issue by adding a check for negative event fd value. Coverity issue: 373711, 373694 Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle") Signed-off-by: Harman Kalra Acked-by: David Marchand --- diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c index 1fd00a482b..bde55a3d92 100644 --- a/lib/eal/linux/eal_dev.c +++ b/lib/eal/linux/eal_dev.c @@ -220,8 +220,10 @@ static void dev_delayed_unregister(void *param) { rte_intr_callback_unregister(intr_handle, dev_uev_handler, param); - close(rte_intr_fd_get(intr_handle)); - rte_intr_fd_set(intr_handle, -1); + if (rte_intr_fd_get(intr_handle) >= 0) { + close(rte_intr_fd_get(intr_handle)); + rte_intr_fd_set(intr_handle, -1); + } } static void @@ -237,6 +239,9 @@ dev_uev_handler(__rte_unused void *param) memset(&uevent, 0, sizeof(struct rte_dev_event)); memset(buf, 0, EAL_UEV_MSG_LEN); + if (rte_intr_fd_get(intr_handle) < 0) + return; + ret = recv(rte_intr_fd_get(intr_handle), buf, EAL_UEV_MSG_LEN, MSG_DONTWAIT); if (ret < 0 && errno == EAGAIN)