From: Aaron Conole <aconole@redhat.com>
Date: Wed, 7 Aug 2019 14:58:44 +0000 (-0400)
Subject: test/mcslock: wait for lcore completion
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=7fb1e84570eb61e508a097176a2f5b046d417311;hp=8b36297d15f90265b50fae211157dff573513359;p=dpdk.git

test/mcslock: wait for lcore completion

It's possible that the mcsunlock occurs before the test_mcslock_try has
a chance to execute, which will result in the trylock being successful,
making the test case fail.  Fix this by waiting until all lcores have
completed their test before unlocking the master lock.

Fixes: 32dcb9fd2a22 ("test/mcslock: add MCS queued lock unit test")

Signed-off-by: Aaron Conole <aconole@redhat.com>
Acked-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
---

diff --git a/app/test/test_mcslock.c b/app/test/test_mcslock.c
index ed384b81d9..e9359df2ee 100644
--- a/app/test/test_mcslock.c
+++ b/app/test/test_mcslock.c
@@ -225,8 +225,8 @@ test_mcslock(void)
 	RTE_LCORE_FOREACH_SLAVE(i) {
 		rte_eal_remote_launch(test_mcslock_try, NULL, i);
 	}
-	rte_mcslock_unlock(&p_ml_try, &ml_try_me);
 	rte_eal_mp_wait_lcore();
+	rte_mcslock_unlock(&p_ml_try, &ml_try_me);
 
 	/* Test is_locked API */
 	if (rte_mcslock_is_locked(p_ml)) {