From: Zhiyong Yang Date: Wed, 7 Sep 2016 06:11:00 +0000 (+0800) Subject: net/virtio: fix xstats name X-Git-Tag: spdx-start~5922 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=81f7234b9e858a7e98bae1eb88bcd02ac93997ce;p=dpdk.git net/virtio: fix xstats name We have a stats named "size_1024_1517_packets", while the code actually counts the range "[1024, 1518]", which is obviously wrong. The code is as follows in the function virtio_update_packet_stats. else if (s < 1519) stats->size_bins[6]++; We could either fix it by correcting the "if" check in the code, or fix it by just renaming the stats to conform to the code. The latter solution is taken because that's what the RFC2819 suggests. Fixes: 76d4c652e07d ("virtio: add extended stats") Signed-off-by: Zhiyong Yang Acked-by: Yuanhan Liu --- diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index b05bb40b70..b4dfc0a9de 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -125,8 +125,8 @@ static const struct rte_virtio_xstats_name_off rte_virtio_rxq_stat_strings[] = { {"size_128_255_packets", offsetof(struct virtnet_rx, stats.size_bins[3])}, {"size_256_511_packets", offsetof(struct virtnet_rx, stats.size_bins[4])}, {"size_512_1023_packets", offsetof(struct virtnet_rx, stats.size_bins[5])}, - {"size_1024_1517_packets", offsetof(struct virtnet_rx, stats.size_bins[6])}, - {"size_1518_max_packets", offsetof(struct virtnet_rx, stats.size_bins[7])}, + {"size_1024_1518_packets", offsetof(struct virtnet_rx, stats.size_bins[6])}, + {"size_1519_max_packets", offsetof(struct virtnet_rx, stats.size_bins[7])}, }; /* [rt]x_qX_ is prepended to the name string here */ @@ -142,8 +142,8 @@ static const struct rte_virtio_xstats_name_off rte_virtio_txq_stat_strings[] = { {"size_128_255_packets", offsetof(struct virtnet_tx, stats.size_bins[3])}, {"size_256_511_packets", offsetof(struct virtnet_tx, stats.size_bins[4])}, {"size_512_1023_packets", offsetof(struct virtnet_tx, stats.size_bins[5])}, - {"size_1024_1517_packets", offsetof(struct virtnet_tx, stats.size_bins[6])}, - {"size_1518_max_packets", offsetof(struct virtnet_tx, stats.size_bins[7])}, + {"size_1024_1518_packets", offsetof(struct virtnet_tx, stats.size_bins[6])}, + {"size_1519_max_packets", offsetof(struct virtnet_tx, stats.size_bins[7])}, }; #define VIRTIO_NB_RXQ_XSTATS (sizeof(rte_virtio_rxq_stat_strings) / \