From: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Date: Mon, 29 Jun 2015 15:06:03 +0000 (+0200)
Subject: cfgfile: fix unitialised buffer
X-Git-Tag: spdx-start~8878
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=8646ea0116df6ef4cdd3c39f94ce53d17724d2cb;p=dpdk.git

cfgfile: fix unitialised buffer

Nature of the problem was not initialised buffer[256], there were probability
that operation system will provide previously used memory and on special condition
there were probability that string operations will work on random data that
could provide unexpected program behaviour.

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---

diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
index b81c2738c2..a677dadecf 100644
--- a/lib/librte_cfgfile/rte_cfgfile.c
+++ b/lib/librte_cfgfile/rte_cfgfile.c
@@ -92,7 +92,7 @@ rte_cfgfile_load(const char *filename, int flags)
 	int allocated_entries = 0;
 	int curr_section = -1;
 	int curr_entry = -1;
-	char buffer[256];
+	char buffer[256] = {0};
 	int lineno = 0;
 	struct rte_cfgfile *cfg = NULL;