From: Kevin Laatz <kevin.laatz@intel.com>
Date: Thu, 19 Apr 2018 11:04:18 +0000 (+0100)
Subject: examples/ip_pipeline: fix leak on connection error
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=89668b1c75dc0a3afeb172d4a16481bad1ba3084;p=dpdk.git

examples/ip_pipeline: fix leak on connection error

Closing the fd_server file descriptor on error to fix the resource leak.

Coverity issue: 272587
Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface")

Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>
---

diff --git a/examples/ip_pipeline/conn.c b/examples/ip_pipeline/conn.c
index 933894251d..6b08e9e8e8 100644
--- a/examples/ip_pipeline/conn.c
+++ b/examples/ip_pipeline/conn.c
@@ -96,12 +96,14 @@ conn_init(struct conn_params *p)
 		sizeof(server_address));
 	if (status == -1) {
 		conn_free(conn);
+		close(fd_server);
 		return NULL;
 	}
 
 	status = listen(fd_server, 16);
 	if (status == -1) {
 		conn_free(conn);
+		close(fd_server);
 		return NULL;
 	}
 
@@ -109,6 +111,7 @@ conn_init(struct conn_params *p)
 	fd_client_group = epoll_create(1);
 	if (fd_client_group == -1) {
 		conn_free(conn);
+		close(fd_server);
 		return NULL;
 	}