From: Ciara Power <ciara.power@intel.com>
Date: Tue, 13 Oct 2020 15:56:48 +0000 (+0100)
Subject: test/telemetry: fix socket resource leak
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=89ce9f09e28f0a07694ce12f4bf331f8ddc8e539;p=dpdk.git

test/telemetry: fix socket resource leak

If an error occurred when reading from the socket, the function
returned without closing the socket. This is now fixed to avoid the
resource leak of the sock variable going out of scope.

Coverity issue: 363043
Fixes: bd78cf693ebd ("test/telemetry: add unit tests for data to JSON")

Signed-off-by: Ciara Power <ciara.power@intel.com>
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
---

diff --git a/app/test/test_telemetry_data.c b/app/test/test_telemetry_data.c
index 00326867b6..f34d691265 100644
--- a/app/test/test_telemetry_data.c
+++ b/app/test/test_telemetry_data.c
@@ -330,6 +330,7 @@ connect_to_socket(void)
 	if (bytes < 0) {
 		printf("%s: Error with socket read - %s\n", __func__,
 				strerror(errno));
+		close(sock);
 		return -1;
 	}
 	buf[bytes] = '\0';