From: Andy Green <andy@warmcat.com>
Date: Thu, 17 May 2018 13:50:17 +0000 (+0800)
Subject: net: explicit cast of protocol in IPv6 checksum
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=8bf255bb3862d8f35496b26bc8c2511239bdc18b;p=dpdk.git

net: explicit cast of protocol in IPv6 checksum

GCC 8.1 warned:

In function 'rte_ipv6_phdr_cksum':
rte_ip.h:378:18: warning: conversion to 'uint32_t' {aka 'unsigned int'}
from 'int' may change the sign of the result [-Wsign-conversion]
  psd_hdr.proto = (ipv6_hdr->proto << 24);

Fixes: 6006818cfb26 ("net: new checksum functions")
Cc: stable@dpdk.org

Signed-off-by: Andy Green <andy@warmcat.com>
---

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index edbe4335cf..c924aca7f1 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -375,7 +375,7 @@ rte_ipv6_phdr_cksum(const struct ipv6_hdr *ipv6_hdr, uint64_t ol_flags)
 		uint32_t proto; /* L4 protocol - top 3 bytes must be zero */
 	} psd_hdr;
 
-	psd_hdr.proto = (ipv6_hdr->proto << 24);
+	psd_hdr.proto = (uint32_t)(ipv6_hdr->proto << 24);
 	if (ol_flags & PKT_TX_TCP_SEG) {
 		psd_hdr.len = 0;
 	} else {