From: Andrew Rybchenko Date: Tue, 3 Nov 2020 14:26:16 +0000 (+0000) Subject: ethdev: deprecate shared counters using action attribute X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=8ca9bf26f585e7ab67a9fca67f4162f11315c6d6;p=dpdk.git ethdev: deprecate shared counters using action attribute A new generic shared actions API may be used to create shared counter. There is no point to keep duplicate COUNT action specific capability to create shared counters. Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit Acked-by: Ajit Khaparde Acked-by: Ori Kam Acked-by: Bruce Richardson --- diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 4cff9332fa..86b3444803 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -1724,17 +1724,20 @@ that counter. For ports within the same switch domain then the counter id namespace extends to all ports within that switch domain. +The shared flag is DEPRECATED and ``SHARED`` ``COUNT`` action should be used +to make shared counters. + .. _table_rte_flow_action_count: .. table:: COUNT - +------------+---------------------+ - | Field | Value | - +============+=====================+ - | ``shared`` | shared counter flag | - +------------+---------------------+ - | ``id`` | counter id | - +------------+---------------------+ + +------------+---------------------------------+ + | Field | Value | + +============+=================================+ + | ``shared`` | DEPRECATED, shared counter flag | + +------------+---------------------------------+ + | ``id`` | counter id | + +------------+---------------------------------+ Query structure to retrieve and reset flow rule counters: diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index f418285d28..ad91102244 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -75,6 +75,10 @@ Deprecation Notices as deprecated in DPDK 20.11, along with the associated macros ``ETH_MIRROR_*``. This API will be fully removed in DPDK 21.11. +* ethdev: Attribute ``shared`` of the ``struct rte_flow_action_count`` + is deprecated and will be removed in DPDK 21.11. Shared counters should + be managed using shared actions API (``rte_flow_shared_action_create`` etc). + * ethdev: Queue specific stats fields will be removed from ``struct rte_eth_stats``. Mentioned fields are: ``q_ipackets``, ``q_opackets``, ``q_ibytes``, ``q_obytes``, ``q_errors``. diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index b98334c5c4..0977a78270 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -2287,6 +2287,9 @@ struct rte_flow_query_age { * Counters can be retrieved and reset through ``rte_flow_query()``, see * ``struct rte_flow_query_count``. * + * @deprecated Shared attribute is deprecated, use generic + * RTE_FLOW_ACTION_TYPE_SHARED action. + * * The shared flag indicates whether the counter is unique to the flow rule the * action is specified with, or whether it is a shared counter. * @@ -2299,7 +2302,8 @@ struct rte_flow_query_age { * to all ports within that switch domain. */ struct rte_flow_action_count { - uint32_t shared:1; /**< Share counter ID with other flow rules. */ + /** @deprecated Share counter ID with other flow rules. */ + uint32_t shared:1; uint32_t reserved:31; /**< Reserved, must be zero. */ uint32_t id; /**< Counter ID. */ };