From: Beilei Xing Date: Tue, 9 Jan 2018 10:37:44 +0000 (+0800) Subject: net/i40e: fix setting MAC address of VF X-Git-Tag: spdx-start~325 X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=8d1e8e70ff4bff2a0135aa970552f1dcc4628e43;p=dpdk.git net/i40e: fix setting MAC address of VF New MAC address is copied to dev->data->mac_addrs[0] before calling setting MAC address ops. So it will fail when deleting dev->data->mac_addrs[0]. Deleting hw->mac.addr will fix the issue. Fixes: 943c2d899a0c ("net/i40e: set VF MAC from VF") Cc: stable@dpdk.org Signed-off-by: Beilei Xing Acked-by: Qi Zhang --- diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 86f94e926f..4d508620a1 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2658,6 +2658,7 @@ i40evf_set_default_mac_addr(struct rte_eth_dev *dev, struct ether_addr *mac_addr) { struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); + struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); if (!is_valid_assigned_ether_addr(mac_addr)) { PMD_DRV_LOG(ERR, "Tried to set invalid MAC address."); @@ -2667,7 +2668,9 @@ i40evf_set_default_mac_addr(struct rte_eth_dev *dev, if (vf->flags & I40E_FLAG_VF_MAC_BY_PF) return; - i40evf_del_mac_addr_by_addr(dev, dev->data->mac_addrs); + i40evf_del_mac_addr_by_addr(dev, (struct ether_addr *)hw->mac.addr); i40evf_add_mac_addr(dev, mac_addr, 0, 0); + + ether_addr_copy(mac_addr, (struct ether_addr *)hw->mac.addr); }