From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Date: Mon, 30 Jun 2014 10:52:55 +0000 (+0100)
Subject: app/test: remove writes in NULL buffer from cmdline tests
X-Git-Tag: spdx-start~10559
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=8d9645381343b66aec2e8e2c71efc3cb9c9a098d;p=dpdk.git

app/test: remove writes in NULL buffer from cmdline tests

Cmdline unit test calls several functions that use snprintf,
with NULL pointer as the destination buffer. This patch
eliminates these NULL pointer tests.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Tested-by: Waterman Cao <waterman.cao@intel.com>
---

diff --git a/app/test/test_cmdline_etheraddr.c b/app/test/test_cmdline_etheraddr.c
index 21f5863734..45c61ff680 100644
--- a/app/test/test_cmdline_etheraddr.c
+++ b/app/test/test_cmdline_etheraddr.c
@@ -161,13 +161,6 @@ test_parse_etheraddr_invalid_param(void)
 	/* test help function */
 	memset(&buf, 0, sizeof(buf));
 
-	/* try null buf */
-	ret = cmdline_get_help_etheraddr(NULL, NULL, sizeof(buf));
-	if (ret != -1) {
-		printf("Error: help function accepted null buffer!\n");
-		return -1;
-	}
-
 	/* coverage! */
 	ret = cmdline_get_help_etheraddr(NULL, buf, sizeof(buf));
 	if (ret < 0) {
diff --git a/app/test/test_cmdline_num.c b/app/test/test_cmdline_num.c
index e865428f84..799d68c94f 100644
--- a/app/test/test_cmdline_num.c
+++ b/app/test/test_cmdline_num.c
@@ -395,13 +395,6 @@ test_parse_num_invalid_param(void)
 		return -1;
 	}
 
-	/* try null buf */
-	ret = cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, NULL, sizeof(buf));
-	if (ret != -1) {
-		printf("Error: help function accepted null buffer!\n");
-		return -1;
-	}
-
 	/* coverage! */
 	ret = cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, buf, sizeof(buf));
 	if (ret < 0) {
diff --git a/app/test/test_cmdline_portlist.c b/app/test/test_cmdline_portlist.c
index abba008d6e..9f9633cd1d 100644
--- a/app/test/test_cmdline_portlist.c
+++ b/app/test/test_cmdline_portlist.c
@@ -164,13 +164,6 @@ test_parse_portlist_invalid_param(void)
 
 	/* test help function */
 
-	/* try null buf */
-	ret = cmdline_get_help_portlist(NULL, NULL, sizeof(buf));
-	if (ret != -1) {
-		printf("Error: help function accepted null buffer!\n");
-		return -1;
-	}
-
 	/* coverage! */
 	ret = cmdline_get_help_portlist(NULL, buf, sizeof(buf));
 	if (ret < 0) {