From: Aleksander Gajewski <aleksanderx.gajewski@intel.com>
Date: Tue, 7 Feb 2017 09:20:18 +0000 (+0100)
Subject: app/crypto-perf: fix string not null terminated
X-Git-Tag: spdx-start~4511
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=8ecd4048ba5d23c016df9a10225972bb78fd8044;p=dpdk.git

app/crypto-perf: fix string not null terminated

This commit fixes the case where the string buffer may not have
a null terminator if the source string's length is equal to the
buffer size.

Coverity issue: 141069
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Aleksander Gajewski <aleksanderx.gajewski@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---

diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c
index 3b7342d918..691e7889a1 100644
--- a/app/test-crypto-perf/cperf_options_parsing.c
+++ b/app/test-crypto-perf/cperf_options_parsing.c
@@ -198,7 +198,8 @@ parse_device_type(struct cperf_options *opts, const char *arg)
 	if (strlen(arg) > (sizeof(opts->device_type) - 1))
 		return -1;
 
-	strncpy(opts->device_type, arg, sizeof(opts->device_type));
+	strncpy(opts->device_type, arg, sizeof(opts->device_type) - 1);
+	*(opts->device_type + sizeof(opts->device_type) - 1) = '\0';
 
 	return 0;
 }