From: Bruce Richardson <bruce.richardson@intel.com>
Date: Tue, 28 Jun 2016 11:27:12 +0000 (+0100)
Subject: scripts: check first word of commit messages
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=9c24780f0d5e;p=dpdk.git

scripts: check first word of commit messages

Avoid messages starting with "It" without describing what
it is talking about.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---

diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index 4253d14b9c..9a0d0683ff 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -114,6 +114,12 @@ bad=$(echo "$headlines" | awk 'length>60 {print}' | sed 's,^,\t,')
 bad=$(echo "$bodylines" | grep -v '^Fixes:' | awk 'length>75 {print}' | sed 's,^,\t,')
 [ -z "$bad" ] || printf "Line too long:\n$bad\n"
 
+# check starting commit message with "It"
+bad=$(echo "$bodylines" | head -n1 | grep -E --color=always \
+	-ie '^It ' \
+	| sed 's,^,\t,')
+[ -z "$bad" ] || printf "Wrong beginning of commit message:\n$bad\n"
+
 # check tags spelling
 bad=$(echo "$tags" |
 	grep -v '^\(Reported\|Suggested\|Signed-off\|Acked\|Reviewed\|Tested\)-by: [^,]* <.*@.*>$' |