From: Nithin Dabilpuram Date: Fri, 21 Jan 2022 12:04:21 +0000 (+0530) Subject: common/cnxk: fix uninitialized variables X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=a3b4864251ea8c77de1bbb7e2a1a570a253ce339;p=dpdk.git common/cnxk: fix uninitialized variables Fix uninitialized variable issues reported by klockwork(static analysis tool). Fixes: ed135040f0ab ("common/cnxk: add CPT LF configuration") Fixes: 585bb3e538f9 ("common/cnxk: add VF support to base device class") Fixes: 58debb813a8d ("common/cnxk: enable TM to listen on Rx pause frames") Cc: stable@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Nithin Dabilpuram Acked-by: Jerin Jacob --- diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c index 3f3d28196b..89877d1b28 100644 --- a/drivers/common/cnxk/roc_cpt.c +++ b/drivers/common/cnxk/roc_cpt.c @@ -817,9 +817,9 @@ roc_cpt_eng_grp_add(struct roc_cpt *roc_cpt, enum cpt_eng_type eng_type) void roc_cpt_iq_disable(struct roc_cpt_lf *lf) { + volatile union cpt_lf_q_grp_ptr grp_ptr = {.u = 0x0}; + volatile union cpt_lf_inprog lf_inprog = {.u = 0x0}; union cpt_lf_ctl lf_ctl = {.u = 0x0}; - union cpt_lf_q_grp_ptr grp_ptr; - union cpt_lf_inprog lf_inprog; int timeout = 20; int cnt; diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c index 0ac50cab59..9a869698c4 100644 --- a/drivers/common/cnxk/roc_dev.c +++ b/drivers/common/cnxk/roc_dev.c @@ -57,7 +57,7 @@ pf_af_sync_msg(struct dev *dev, struct mbox_msghdr **rsp) struct mbox *mbox = dev->mbox; struct mbox_dev *mdev = &mbox->dev[0]; - volatile uint64_t int_status; + volatile uint64_t int_status = 0; struct mbox_msghdr *msghdr; uint64_t off; int rc = 0; diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c index 3b38cc087b..a0448bec61 100644 --- a/drivers/common/cnxk/roc_nix_tm.c +++ b/drivers/common/cnxk/roc_nix_tm.c @@ -424,7 +424,7 @@ nix_tm_bp_config_get(struct roc_nix *roc_nix, bool *is_enabled) if (req) { req->num_regs = k; - rc = mbox_process(mbox); + rc = mbox_process_msg(mbox, (void **)&rsp); if (rc) goto err; /* Report it as enabled only if enabled or all */