From: Qi Zhang Date: Tue, 10 Aug 2021 02:51:22 +0000 (+0800) Subject: net/ice/base: clarify comments on checking PFC mode X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=a3f1d0e4fc2b0abf63e5f04e099541aa27ee69dc;p=dpdk.git net/ice/base: clarify comments on checking PFC mode Rework the comment around checking PFC mode to make it clear why we are checking the mode after sending the command. Signed-off-by: Tony Nguyen Signed-off-by: Qi Zhang Acked-by: Junfeng Guo --- diff --git a/drivers/net/ice/base/ice_dcb.c b/drivers/net/ice/base/ice_dcb.c index 9c9675f6ef..cb6c5ba182 100644 --- a/drivers/net/ice/base/ice_dcb.c +++ b/drivers/net/ice/base/ice_dcb.c @@ -764,11 +764,10 @@ ice_aq_set_pfc_mode(struct ice_hw *hw, u8 pfc_mode, struct ice_sq_cd *cd) if (status) return status; - /* The spec isn't clear about whether the FW will return an error code - * if the PFC mode requested by the driver was not set. The spec just - * says that the FW will write the PFC mode set back into cmd->pfc_mode, - * so after the AQ has been executed, check if cmd->pfc_mode is what was - * requested. + /* FW will write the PFC mode set back into cmd->pfc_mode, but if DCB is + * disabled, FW will write back 0 to cmd->pfc_mode. After the AQ has + * been executed, check if cmd->pfc_mode is what was requested. If not, + * return an error. */ if (cmd->pfc_mode != pfc_mode) return ICE_ERR_NOT_SUPPORTED;