From: David Marchand Date: Fri, 18 Mar 2022 15:03:31 +0000 (+0100) Subject: net/bnxt: fix compatibility with some old firmwares X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=a43d0129579034af06314b6603d92a866d809eeb;p=dpdk.git net/bnxt: fix compatibility with some old firmwares This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. Reported by Red Hat QE: with older firmware versions (at least versions 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this change. Revert it for now, waiting for a more complete fix. Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Ajit Khaparde --- diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 6e4753c508..9eb8b8d56d 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1249,11 +1249,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) else HWRM_CHECK_RESULT(); - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) { - rc = -EAGAIN; - goto error; - } - PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n", resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b, resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b, @@ -6154,10 +6149,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp) rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB); HWRM_CHECK_RESULT_SILENT(); - - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) - rc = -EAGAIN; - HWRM_UNLOCK(); return rc;