From: Olivier Matz <zer0@droids-corp.org>
Date: Thu, 1 Mar 2018 14:21:28 +0000 (+0100)
Subject: don't use atoi
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=af093c6301f15fbf7cf86ecaa1ae5da5a5edfda1;p=protos%2Flibecoli.git

don't use atoi
---

diff --git a/lib/ecoli_node_expr_test.c b/lib/ecoli_node_expr_test.c
index f14cf50..a26fe08 100644
--- a/lib/ecoli_node_expr_test.c
+++ b/lib/ecoli_node_expr_test.c
@@ -51,7 +51,9 @@ ec_node_expr_test_eval_var(void **result, void *userctx,
 	const struct ec_parsed *var)
 {
 	const struct ec_strvec *vec;
-	struct my_eval_result *eval;
+	const struct ec_node *node;
+	struct my_eval_result *eval = NULL;
+	int64_t val;
 
 	(void)userctx;
 
@@ -60,11 +62,15 @@ ec_node_expr_test_eval_var(void **result, void *userctx,
 	if (ec_strvec_len(vec) != 1)
 		return -EINVAL;
 
+	node = ec_parsed_get_node(var);
+	if (ec_node_int_getval(node, ec_strvec_val(vec, 0), &val) < 0)
+		return -EINVAL;
+
 	eval = ec_malloc(sizeof(*eval));
 	if (eval == NULL)
 		return -ENOMEM;
 
-	eval->val = atoi(ec_strvec_val(vec, 0)); // XXX use strtol
+	eval->val = val;
 	printf("eval var %d\n", eval->val);
 	*result = eval;