From: Jiawen Wu Date: Fri, 5 Nov 2021 02:01:17 +0000 (+0800) Subject: net/txgbe: fix link process in KR mode X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=b4ce1520c945ea739d53cbdb250c443818915e6b;p=dpdk.git net/txgbe: fix link process in KR mode Set the 'present' parameter to 0 by default. It is configured by hardware, users can set it to 1 for manual configuration. Fixes: f611dada1af8 ("net/txgbe: update link setup process of backplane NICs") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- diff --git a/doc/guides/nics/txgbe.rst b/doc/guides/nics/txgbe.rst index 47501796f2..5b29f1de0c 100644 --- a/doc/guides/nics/txgbe.rst +++ b/doc/guides/nics/txgbe.rst @@ -110,7 +110,7 @@ Please note that following ``devargs`` are only set for backplane NICs. Toggle behavior to enable/disable polling mode to receive AN interrupt. -- ``present`` (default **1**) +- ``present`` (default **0**) Toggle behavior to use present mode or init mode. diff --git a/drivers/net/txgbe/base/txgbe_phy.c b/drivers/net/txgbe/base/txgbe_phy.c index 2db87ae0c5..3f5229ecc2 100644 --- a/drivers/net/txgbe/base/txgbe_phy.c +++ b/drivers/net/txgbe/base/txgbe_phy.c @@ -1456,7 +1456,7 @@ txgbe_set_link_to_kr(struct txgbe_hw *hw, bool autoneg) wr32_epcs(hw, SR_AN_CTRL, 0); wr32_epcs(hw, VR_AN_KR_MODE_CL, 0); } - if (hw->devarg.present == 1) { + if (hw->devarg.present == 1) { value = rd32_epcs(hw, TXGBE_PHY_TX_EQ_CTL1); value |= TXGBE_PHY_TX_EQ_CTL1_DEF; wr32_epcs(hw, TXGBE_PHY_TX_EQ_CTL1, value); diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 5c31ba5358..04afc61341 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -495,7 +495,7 @@ txgbe_parse_devargs(struct txgbe_hw *hw, struct rte_devargs *devargs) struct rte_kvargs *kvlist; u16 auto_neg = 1; u16 poll = 0; - u16 present = 1; + u16 present = 0; u16 sgmii = 0; u16 ffe_set = 0; u16 ffe_main = 27;