From: John Daley <johndale@cisco.com>
Date: Wed, 14 Oct 2020 20:25:22 +0000 (-0700)
Subject: net/enic: check in error path
X-Git-Url: http://git.droids-corp.org/?a=commitdiff_plain;h=b51a6d07fa9ac6a6ae6c45f7b36d61a0501bcc17;p=dpdk.git

net/enic: check in error path

Coverity issue: 363046
Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")

Signed-off-by: John Daley <johndale@cisco.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---

diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c
index 96ec360a85..9cea94269c 100644
--- a/drivers/net/enic/enic_fm_flow.c
+++ b/drivers/net/enic/enic_fm_flow.c
@@ -2232,7 +2232,11 @@ enic_action_handle_get(struct enic_flowman *fm, struct fm_action *action_in,
 error_with_action_handle:
 	args[0] = FM_ACTION_FREE;
 	args[1] = ah->handle;
-	flowman_cmd(fm, args, 2);
+	ret = flowman_cmd(fm, args, 2);
+	if (ret != 0)
+		rte_flow_error_set(error, -ret,
+				   RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+				   NULL, "enic: devcmd(action-free)");
 error_with_ah:
 	free(ah);
 	return ret;